I have to preface this with I truly respect the idea and the gentleman who initiated ScriptCop. That said it sort of brings up a sore point that struck me during the last Scripting games.
I am all for beautiful functioning code but Powershell seems to have brought a large amount of developer oriented folks into the community and the mix with System Administrators becomes interesting. When I first started with Powershell I was doing lots of vbscript so I was able to focus on code and listening to the great minds who were not just teaching the powerful language but to optimize it.
I would love to sit and perfect my code, but as my new job dictates, there isn’t time to write beautiful code. And that is just one issue I have with the critiquing. Granted I think that an employer who wants you to apply Powershell technology but doesn’t think you should spend time doing it right is problematic but, that is how it is. Additionally when I write code, I have to think about it’s readability, and readability amongst a varied expertise. Things like long concise pipelines. They look very cool and are normally very proficient, but think about the SysAdmin who might have to perform an after hours support call when it isn’t functioning correctly. Despite the huge powershell community, my day to day experience indicates there are more Windows System Administrators that are not even looking at Powershell and most never progressed beyond batch files. Breaking a pipeline into separate steps is just a more debuggable format in my opinion.
I do think ScriptCop is a great idea but maybe applied more towards a uniform way to apply approved standards to a library of scripts.